This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[ios] Cherry-pick #13427 - Expose "local ideograph font family" in map snapshotters #13547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions Use local glyph generation in test app's MapSnapshotterActivity.
ChrisLoer
approved these changes
Dec 11, 2018
|
@ChrisLoer Yeah, it looks like a higher version of cmake is required than is in the branch. I'm not sure if there is something I can bring into the branch so that they can pass. |
|
@kkaefer Do you have any pointers for getting the linux builds running on the ios8 branch again? It also seems somewhat reasonable to just ignore or disable these builds, since this branch is only used for iOS (although the sanitize builds are meant to catch errors that could show up on any platform). |
|
918e571 should fix this build |
|
Thanks @kkaefer! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cherry-picks #13427 into the iOS 8 branch.
cc @lloydsheng @chriswu42