Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Use locale sensitive DecimalFormat for color alpha conversion #13393

Merged
merged 1 commit into from
Nov 20, 2018
Merged

Use locale sensitive DecimalFormat for color alpha conversion #13393

merged 1 commit into from
Nov 20, 2018

Conversation

LukasPaczos
Copy link
Contributor

Fixes an issue where the alpha value of the ColorInt -> String conversion would be converted with a system locale instead of the fixed one.

@LukasPaczos LukasPaczos added the Android Mapbox Maps SDK for Android label Nov 16, 2018
@LukasPaczos LukasPaczos added this to the android-v7.0.0-iowaska milestone Nov 16, 2018
@LukasPaczos LukasPaczos requested a review from tobrun November 16, 2018 13:17
tobrun
tobrun approved these changes Nov 20, 2018
View reviewed changes
Copy link
Member

@tobrun tobrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, this change might be worth cherry picking if we do another patch release in the near future.

@LukasPaczos LukasPaczos merged commit 1d73bda into master Nov 20, 2018
@LukasPaczos LukasPaczos deleted the lp-color-alpha-decimal-format branch November 20, 2018 11:21
@LukasPaczos LukasPaczos mentioned this pull request Nov 21, 2018
Closed
@LukasPaczos LukasPaczos mentioned this pull request Dec 18, 2018
Closed
@tobrun tobrun mentioned this pull request Dec 19, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tobrun tobrun tobrun approved these changes

Assignees
No one assigned
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Milestone
android-v6.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@LukasPaczos @tobrun