-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[build] Update CircleCI jobs to Xcode 10.0 #13184
Conversation
9ba9e0c
to
017c3c1
Compare
Tests are exceeding even the 10 second timeout on CI: https://circleci.com/gh/mapbox/mapbox-gl-native/183935
https://circleci.com/gh/mapbox/mapbox-gl-native/184371
|
@julianrex do you see any alternative to indefinitely bumping timeouts? Flappy tests are (to my mind) worse than no tests, so I’d vote for disabling timing-dependent tests entirely on CI if we can’t resolve this issue. |
Agreed - let's disable until we can come up with a longer term solution, that doesn't require us to constantly tweak fragile settings! |
Per chat with @julianrex we’re going to stop running the Integration Tests target on CircleCI for now. |
8dd886c
to
e26a032
Compare
Rebased and ready for review. |
Some persistent, strange, and seemingly unrelated failures with two of the gcc jobs (
/cc @tmpsantos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes here look good (no idea what's happening with the build failures though)
These are evidently too inconsistent to run on CircleCI under Xcode 10.
e26a032
to
947af30
Compare
/cc @mapbox/maps-ios