-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Let placement transitions use the transition duration, if set, and allow disabling them entirely #13035
Conversation
This looks to me like it "does what it says", and I played around with it in the
If we're going to add this to the API, my preference would be to go all the way to implementing the controllable "fadeDuration" used by GL JS, just in the name of consistency. I think we would have to switch the "hold for fade" logic to be closer to GL JS (see https://github.com/mapbox/mapbox-gl-js/blob/5d9027cf8127b5d5972e7d5aa162d8d8d391afd7/src/source/source_cache.js#L537-L544) instead of the current approach on native which just holds tiles until two placements have happened. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I started looking at this again with an eye towards making it closer to GL JS and decided the behavior's actually close enough already. I think we can just merge -- although it would be good to add a changelog entry and some hint for the platform teams that there's a new value to expose (cc @julianrex @LukasPaczos )
… and allow disabling them entirely
dce5ede
to
78598ac
Compare
Added a follow-up in #13438 that adds a new style setter for optional persistent transition options. Style or runtime-defined transition options are reset whenever the style changes. Thus, this allows transition options to persist in such cases. |
This PR:
@ChrisLoer @ansis please review.