This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] don't prefetch tiles for geojson sources #12529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkaefer
approved these changes
Aug 2, 2018
|
Thanks for running with this one @mollymerp! Does this PR impact prefetching for GeoJSON sources that are described with just a URL? |
|
Yes, it should impact both url and text GeoJSON sources @LukasPaczos |
|
Thanks for confirming @mollymerp. |
This was referenced Sep 25, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't make sense to prefetch GeoJSON tiles because there aren't any network calls associated with loading tiles from geojson-vt, and prefetching causes overdraw flickering to be much worse which is affecting users.
Related to #11877 (comment)
@1ec5 @LukasPaczos I took a quick look and didn't see any, but are there docs/examples I need to update reflecting this change?