This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Range alpha between 0 and 1 for android int color conversion #12210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobrun
force-pushed
the
tvn-color-conversion-fix
branch
from
1f63293 to
c015102
Compare
LukasPaczos
suggested changes
Jun 26, 2018
There was a problem hiding this comment.
Thanks for running with that! A couple of comments below. Also, updating raw test would be great.
| * | ||
| * @param color Android color int | ||
| * @return String rgba color | ||
| */ | ||
| public static String colorToRgbaString(@ColorInt int color) { | ||
| return String.format(Locale.US, "rgba(%d, %d, %d, %d)", | ||
| (color >> 16) & 0xFF, (color >> 8) & 0xFF, color & 0xFF, (color >> 24) & 0xFF); | ||
| return String.format(Locale.US, "rgba(%d, %d, %d, %.1f)", |
There was a problem hiding this comment.
I don't think precision to only one decimal point will be enough in this case. What about increasing this to 3?
|
|
||
| @Test | ||
| public void testAlphaValueInStringConversion() { | ||
| String color = PropertyFactory.colorToRgbaString(Color.parseColor("#80FF0000")); // 50% alpha red |
There was a problem hiding this comment.
Could you rewrite this test to include the issue mentioned above?
tobrun
force-pushed
the
tvn-color-conversion-fix
branch
2 times, most recently
from
10089d4 to
2c4ab75
Compare
LukasPaczos
reviewed
Jun 26, 2018
| @Test | ||
| public void testAlphaValueInStringConversion() { | ||
| String color = PropertyFactory.colorToRgbaString(Color.parseColor("#80FF0000")); // 50% alpha red | ||
| String alpha = color.split(" ")[3].substring(0, 3); |
There was a problem hiding this comment.
This test case doesn't really test the implementation as we are cutting off the number on the first decimal point.
tobrun
force-pushed
the
tvn-color-conversion-fix
branch
3 times, most recently
from
c837167 to
491416d
Compare
tobrun
force-pushed
the
tvn-color-conversion-fix
branch
from
491416d to
83328fb
Compare
LukasPaczos
approved these changes
Jun 27, 2018
tobrun
force-pushed
the
tvn-color-conversion-fix
branch
from
83328fb to
2edb0d2
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12198