This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Fix match stop conversion #12128
Merged
Fix match stop conversion #12128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobrun
force-pushed
the
tvn-remove-exception
branch
from
9cb609c to
65f04a6
Compare
|
Capturing from chat with @LukasPaczos, instead of removing the exception, let's fix this up in the expression conversion code. Atm we will wrap expressions with literal when used with match. By hooking into |
tobrun
changed the title
tobrun
force-pushed
the
tvn-remove-exception
branch
from
65f04a6 to
ddc4b03
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12101, this PR needs a CP to release-chai.