This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
always commit placement to fix #11795 #12076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since placements will be committed even if they do not need the full fade duration to fade features in, we need the new `fadeStartTime` to keep track of how long we still need to fade. This is important because if we fade too long we will trigger another placement and never stop rendering.
ChrisLoer
approved these changes
Jun 7, 2018
|
🤔 Sorry I should have tried this before approving, but I just reproduced #11795 on top of this branch. I'll try to figure out what's going on there. |
|
Nevermind, it looked like the same problem but it was actually just that the reproduction case's query geometry didn't go all the way to the bottom of the viewport and I happened to be doing queries near the boundary. |
friedbunny
added
Core
This was referenced Jun 11, 2018
friedbunny
removed
the
needs changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #11795
Since placements will be committed even if they do not need the full fade duration to fade features in, we need the new
fadeStartTimeto keep track of how long we still need to fade. This is important because if we fade too long we will trigger another placement and never stoprendering.
I think the important thing that needs to be reviewed is that the logic that prevents infinite rendering is sound.