This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Style JSON configuration on map snapshotter #11976
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11974 , this PR adds the ability to use a local style.json file as style for a map snapshotter. This option is needed to port our node render tests to Android in #10047.
@LukasPaczos would you be able to review the java code?
@ChrisLoer would you be able to review the core code? (I'm not satisfied with current optional setup, is there a way to make this cleaner? variant or other c++ construct?)