Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

expose MapView#setOfflineRegionDefinition #11922

Merged
merged 1 commit into from
May 17, 2018
Merged

Conversation

tobrun
Copy link
Member

@tobrun tobrun commented May 16, 2018

closes #11876

@tobrun tobrun added the Android Mapbox Maps SDK for Android label May 16, 2018
@tobrun tobrun added this to the android-v6.2.0 milestone May 16, 2018
@tobrun tobrun self-assigned this May 16, 2018
@tobrun tobrun requested a review from LukasPaczos May 16, 2018 14:25
return;
}
nativeMapView.jumpTo(cameraPosition.bearing, cameraPosition.target, cameraPosition.tilt, cameraPosition.zoom);
nativeMapView.setMinZoom(regionDefinition.getMinZoom());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rather use MapView methods for this operations? That'd make a transition to the ViewModel later on easier.

@tobrun tobrun force-pushed the tvn-expose-setofflineregion branch from e5717ed to 8eb7eaa Compare May 17, 2018 16:43
@tobrun tobrun force-pushed the tvn-expose-setofflineregion branch from 8eb7eaa to d25447c Compare May 17, 2018 16:45
@tobrun tobrun merged commit 4f2002b into master May 17, 2018
@tobrun tobrun deleted the tvn-expose-setofflineregion branch July 23, 2018 12:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose MapView#setOfflineRegion
2 participants