This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Remove fragment flash #10717
Merged
Remove fragment flash #10717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasPaczos
suggested changes
Dec 18, 2017
|
|
||
| private final List<OnMapReadyCallback> mapReadyCallbackList = new ArrayList<>(); |
There was a problem hiding this comment.
Since we don't have an API with a list of listeners for OnMapReadyCallback when instantiating it by hand I don't know why should we include it here. Was that a requested feature?
| @Override | ||
| public void onMapReady(MapboxMap mapboxMap) { | ||
| this.mapboxMap = mapboxMap; | ||
| if (!mapReadyCallbackList.isEmpty()) { |
There was a problem hiding this comment.
This check's redundant. Besides that, the same question as above about the list.
There was a problem hiding this comment.
This check is not redundant, checking if a list is not empty before looping it will avoid creating an iterator. In code path that are called often this can make a difference. In this case though it doesn't result in any significant memory growth since it's only called once. I will remove it.
…lback for multiple listeners
tobrun
force-pushed
the
tvn-remove-fragment-flash
branch
from
8b14456 to
a82f959
Compare
LukasPaczos
approved these changes
Dec 18, 2017
mappy-mobile
pushed a commit
to Mappy/mapbox-gl-native
that referenced
this pull request
Dec 26, 2017
* mapbox_release_5.3: (25 commits) [android] - update changelog for 5.3.0 [android] added map touch listeners api based on lists [android] Tweak TinySDF docs to better describe font-family behavior. Saving/restoring MyLocationViewSettings (mapbox#10746) (mapbox#10748) [android] Updated Spanish, Vietnamese translations Android SDK renaming (mapbox#10609) [android] - use default icon when compass icon fails to decode (mapbox#10694) [android] - remove startup flash from fragment, rework OnMapReady callback for multiple listeners (mapbox#10717) [android] Add Configuration hook for local ideograph font family and demo activity [android] Android implementation of local CJK glyph rendering - Draws bold version of glyph if font stack contains string "bold" - Not hooked up to global configuration yet [core] Hook LocalGlyphRasterizer "font family" configuration up to Renderer [core] Enable local glyph generation using TinySDF. - Platform-specific LocalGlyphRasterizer is responsible for deciding which glyphs to rasterize locally and for implementing the rasterization. - Default platform implementation doesn't locally generate any glyphs -> no behavior change - Unit test uses StubLocalGlyphRasterizer, which returns a single fixed bitmap for all CJK glyphs - Rename glyph_loader.test to glyph_manager.test [core] C++ port of TinySDF [ios, macos] Cleaned up base localization files [android] - update instrumented make target, move code style validation before building C++ code, replace code style checks with the wrapper code style check. (mapbox#10724) [android] - activate filesource when creating an offline region (mapbox#10718) [ios] update constraints when updating content inset [ios] Fix an Interface Builder crash for IBInspectable properties. [ios] Fix the content insets for the scale and compass view. Post camera listener invocations (mapbox#10690) ... # Conflicts: # platform/android/MapboxGLAndroidSDK/gradle.properties # platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/http/HTTPRequest.java # platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/maps/MapGestureDetector.java # platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/maps/MapView.java # platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/maps/MapboxMap.java
This was referenced Jan 22, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR optimises showing a Map inside a fragment by hiding the surface on startup and only making it visible when the map is ready. Additionally this PR also allows to use multiple subscribers for OnMapReady events.
before
after