Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Correctly alter sprite URLs #10213

Merged
merged 1 commit into from
Oct 17, 2017
Merged

Correctly alter sprite URLs #10213

merged 1 commit into from
Oct 17, 2017

Conversation

kkaefer
Copy link
Member

@kkaefer kkaefer commented Oct 17, 2017

Fixes #10201 by correctly parsing the sprite URL, and attaching the query string to the end.

/cc @caneroj1

@kkaefer kkaefer requested a review from jfirebaugh October 17, 2017 21:04
Copy link
Contributor

@jfirebaugh jfirebaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an equivalent issue for gl-js?

@caneroj1
Copy link

@kkaefer Well, thanks for the quick turnaround! I had a PR in the works, too, but this is good.

This change would affect all platforms, right? Any ideas on when we would see these changes in a release?

@kkaefer kkaefer merged commit 10f7af1 into master Oct 17, 2017
@kkaefer kkaefer deleted the sprite-query-parameters branch October 17, 2017 22:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants