This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
Fix getFilter with distance expression crash. #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmiao
reviewed
May 12, 2020
MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/style/expressions/Expression.java
Outdated
Show resolved
Hide resolved
alexshalamov
suggested changes
May 12, 2020
There was a problem hiding this comment.
Why do we need gl-native master? I think we need to stick to gl-native 1.6.0 release, so that this PR can be cherry picked to 9.2.0 release
/cc @tobrun
tobrun
reviewed
May 14, 2020
MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/style/expressions/Expression.java
Outdated
Show resolved
Hide resolved
tobrun
approved these changes
May 14, 2020
alexshalamov
approved these changes
May 14, 2020
Chaoba
pushed a commit
that referenced
this pull request
May 14, 2020
* Fix getFilter with distance expression crash. * Update gl-native and test case * Bump gl-native to maps-1.6.0 * Update review comment. (cherry picked from commit 0010a58)
Chaoba
pushed a commit
that referenced
this pull request
May 14, 2020
* Fix binary size. (#382) Add compiler and linker options to reduce binary size for release build: - reduce symbol visibility: `-fvisibility=hidden`, `-fvisibility-inlines=hidden`; - link time optimization `-flto` and enable gold plugin; - remove duplicated code: `–icf=all`; - size optimization for compilation (`-Oz`); - garbage collect unused sections: `-Wl,--gc-sections` (cherry picked from commit 05974e2) * Reset AndroidRendererBackend properly to prevent a crash during rotation on an Android 4.2.2 x86 tablet. (#381) Co-authored-by: Tsoi Yat Shing <[email protected]> (cherry picked from commit d319e17) * Fix getFilter with distance expression crash. (#380) * Fix getFilter with distance expression crash. * Update gl-native and test case * Bump gl-native to maps-1.6.0 * Update review comment. (cherry picked from commit 0010a58) * Update changelog for 9.2.1 (#384) * Update changelog for 9.2.1 * Update changelog for 9.2.1 (cherry picked from commit f8fade5) Co-authored-by: Igor Tarasov <[email protected]> Co-authored-by: Tobrun <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<changelog>Fixed a crash while Layer.getFilter() has expression distance content. </changelog>Update getFilter test for expression within and distance.