Update changelog for 9.2.0-alpha.1 #329
Conversation
CHANGELOG.md
Outdated
| [Changes](https://github.com/mapbox/mapbox-gl-native-android/compare/android-v9.1.0...android-v9.2.0-alpha.1) since [Mapbox Maps SDK for Android v9.1.0](https://github.com/mapbox/mapbox-gl-native-android/releases/tag/android-v9.1.0): | ||
| ### Features | ||
| - Added methods to set and get a limit for how much parent tile can be overscaled for a source.([#299](https://github.com/mapbox/mapbox-gl-native-android/pull/299)) | ||
| - Added API to add stretchable image to a map. Stretchable image could be used as a background for text and be stretched by configuration to adapt the text content. ([#314](https://github.com/mapbox/mapbox-gl-native-android/pull/314)) |
There was a problem hiding this comment.
Not a bad changelog entry. The two things that are missing is mention of the stretch metadata and the usage with icon-text-fit. I suggest the following entry below.
Note: I've used the iOS changelog entry as a starting point and linked to the GL JS ticket for more info about the stretch metadata.
Co-Authored-By: Chloe Krawczyk <[email protected]>
Co-Authored-By: Chloe Krawczyk <[email protected]>
Co-Authored-By: Chloe Krawczyk <[email protected]>
Co-Authored-By: Chloe Krawczyk <[email protected]>
There was a problem hiding this comment.
Thanks for making the changes - LGTM!
Note: for the git release tag, we'll want to start with:
[Changes](https://github.com/mapbox/mapbox-gl-native-android/compare/android-v9.1.0...android-v9.2.0-alpha.1) since [Mapbox Maps SDK for Android v9.1.0](https://github.com/mapbox/mapbox-gl-native-android/releases/tag/android-v9.1.0):
There was a problem hiding this comment.
By the way, mapbox/mapbox-gl-native-ios#272 adds changelog entries for some of the same changes.
| ## 9.2.0-alpha.1 - April 21, 2020 | ||
| ### Features | ||
| - The [`SymbolLayer.iconTextFit`](https://docs.mapbox.com/android/api/map-sdk/9.1.0/com/mapbox/mapboxsdk/style/layers/PropertyFactory.html#iconTextFit-com.mapbox.mapboxsdk.style.expressions.Expression-) property now respects the stretch metadata of any nine-part stretchable image passed into the `style.addImage` method. You can define the stretchable area of an image by configuring the `stretchX`, `stretchY`, `content` options on `Style.addImage` to append the requisite [metadata](https://github.com/mapbox/mapbox-gl-js/issues/8917). ([#314](https://github.com/mapbox/mapbox-gl-native-android/pull/314)) | ||
| - Added methods to set and get the sort key of features in a `CircleLayer` at runtime. Features with a higher sort key will appear above features with a lower sort key. ([#322](https://github.com/mapbox/mapbox-gl-native-android/pull/322)) |
There was a problem hiding this comment.
It might be a difference without a distinction, but I think there’s a PropertyFactory method to set the sort key now; there isn’t a setter on CircleLayer itself.
There was a problem hiding this comment.
Yeah, good point. Currently this entry is consistent with the changelog entries in 9.1.0 for the other sort key properties we added. I'm OK merging as is, though it can be improved.
To your main point, I am unsure of the best way to cite style properties by name on Android. For the previous entry, I asked @Chaoba whether we should write PropertyFactory.iconTextFit or SymbolLayer.iconTextFit and he said the latter. I also prefer the latter because it looks better and would be consistent with iOS and GL JS, but I can't tell if SymbolLayer.iconTextFit is inaccurate or misleading for developers who use our Android SDK.
@mapbox/maps-android, could you shed light on how PropertyFactory works (e.g. where the relationship between the PropertyFactory class and the *Layer classes for each layer type is established), and what you would suggest for describing style properties by name?
|
#sorrynotsorry for abusing the "commit suggestion" feature to tidy up the changelog 🙃. Once CI is green, we can squash and merge. Since I wanted to add the logging thread change as a changelog entry anyway, I used the same commit to update a few of the bug fix entries to match @1ec5's more concise phrasing in the iOS changelog. It's not critical that we have the same entries on both platforms' changelogs. |
* Incorporate changes since 9.1.0 and changes in GL Native maps-v1.6.0-rc.1 Co-authored-by: Chloe Krawczyk <[email protected]> (cherry picked from commit ec15d86)
This pr update changelog for 9.2.0-alpha.1