Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon-text-fit collision tests #8747

Merged
merged 2 commits into from
Sep 11, 2019

Conversation

alexshalamov
Copy link
Contributor

Three new render tests requested in #8722 (comment)

Copy link
Contributor

@asheemmamoowala asheemmamoowala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~The both-collision-variable-anchor test has an expected image that is not correct. I think it is displaying an existing bug that should be addressed . ~

I misunderstood the test 🤕

@alexshalamov
Copy link
Contributor Author

@asheemmamoowala thanks for review!

@alexshalamov alexshalamov merged commit dc3c82c into master Sep 11, 2019
@alexshalamov alexshalamov deleted the alexshalamov_icon_text_fit_collision_tests branch September 11, 2019 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants