Add ['heatmap-density'] expression #5350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @mourner |
mourner
requested changes
Sep 28, 2017
|
Oops, yep will fix. Re: default values hack -- I sorta think the existing hack is alright / involves the minimal amount of special-case code. Can we keep that as is? |
I mean, the requirement to have |
|
Oh, right, sorry! Yeah, let me try to tack on a fix here. |
|
@mourner when I remove the |
|
Heh, maybe you or me accidentally fixed this somehow in other commits :) |
mourner
approved these changes
Sep 28, 2017
mourner
pushed a commit
that referenced
this pull request
Sep 29, 2017
* Add ['heatmap-density'] expression * Fix lint
anandthakker
added a commit
that referenced
this pull request
Oct 2, 2017
* Add ['heatmap-density'] expression * Fix lint
anandthakker
added a commit
that referenced
this pull request
Oct 5, 2017
* Add ['heatmap-density'] expression * Fix lint
mourner
pushed a commit
that referenced
this pull request
Oct 6, 2017
* Add ['heatmap-density'] expression * Fix lint
mourner
added a commit
that referenced
this pull request
Oct 6, 2017
* WIP dump heatmap layer * remove redundant heatmap attributes * cleanup heatmap style reference * stop-based heatmap color ramps * simplify heatmap debug page; remove weight scale * optimize heatmap texture caching logic * make sure no-data areas are always transparent * faster heatmap kernel calculation * fix heatmap blending issues around edges * saner heatmap color ramp defaults * introduce heatmap-intensity property * use texture class for heatmaps * fix bug with heatmap resizing * cache color ramp texture * hack to get rid of heatmap flicker * cache viewport buffer/vao * heatmap fallback when no half-floats available * fix flow errors and some caught bugs * update error message fixtures * Scale mesh to ensure it's large enough for kernel to drop to zero Also change kernel bandwidth from 5.0 to 3.0 * use a smaller heatmap zero for less artifacts * nicer heatmap debug page * add more heatmap code comments * more heatmap code cleanup * gracefully fallback on bad half-float framebuffer support * fix infinite loop in heatmap code * Add ['heatmap-density'] expression (#5350) * Add ['heatmap-density'] expression * Fix lint * better heatmap docs * fix heatmap docs generation * add heatmap render tests * clarify heatmap-density description * add a comment about overriding setPaintProperty * Special case handling for heatmap-color expression default values * add a test for heatmap color expression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
["heatmap-density"]expression and special-case handling when converting stop functions to use that instead of["zoom"]for theheatmap-colorstyle property.