Update docs and test to newer version of mapbox-gl-rtl-text plugin #4847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to
mapbox-gl-rtl-textv0.1.1 to take advantage of smaller package size due to newer version of Emscripten (1.37) stripping more out of the runtime.I've done sanity checks of the example page, and the Arabic unit tests pass with the new build. I've also tested "time to first tile load" by logging a timestamp from
VectorTileSource#done, and don't see a noticeable performance change. The plugin isn't used by our benchmarks, so they're unaffected.