Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flowtype definitions for mapbox-gl style. #4632

Merged
merged 1 commit into from
Jul 10, 2017

Conversation

vicapow
Copy link
Contributor

@vicapow vicapow commented Apr 24, 2017

No description provided.

@vicapow
Copy link
Contributor Author

vicapow commented Apr 26, 2017

To follow up, these style definitions aren't used anywhere yet, but I wanted to seperate them out into a seperate commit. I guess I could instead submit the full changes of this being used in at least one file first?

@jfirebaugh
Copy link
Contributor

I think we definitely want these, but it would probably be best to generate them from the style spec JSON so we don't have two sources of truth.

BTW, thanks for all the PRs adding flow types!

@vicapow
Copy link
Contributor Author

vicapow commented Jun 29, 2017

I think we definitely want these, but it would probably be best to generate them from the style spec JSON so we don't have two sources of truth.
Could you point me to the style spec JSON definition?
BTW, thanks for all the PRs adding flow types!
You're welcome! Glad to help

@jfirebaugh
Copy link
Contributor

@jfirebaugh
Copy link
Contributor

Started on this #4958. I'm going to pull in your TileJSON definition though.

@jfirebaugh jfirebaugh merged commit c860b89 into mapbox:master Jul 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants