Revamp plugin documentation & strip plugin publishing functionality #4305
Conversation
| tags: | ||
| - controls-and-overlays | ||
| --- | ||
| <script src='https://api.mapbox.com/mapbox-gl-js/plugins/mapbox-gl-geocoder/v{{site.data.plugins.mapbox-gl-geocoder.latest}}/mapbox-gl-geocoder.js'></script> | ||
| <link rel='stylesheet' href='https://api.mapbox.com/mapbox-gl-js/plugins/mapbox-gl-geocoder/v{{site.data.plugins.mapbox-gl-geocoder.latest}}/mapbox-gl-geocoder.css' type='text/css' /> | ||
| <script src='https://api.mapbox.com/mapbox-gl-js/plugins/mapbox-gl-geocoder/v2.0.1/mapbox-gl-geocoder.js'></script> |
There was a problem hiding this comment.
What's the plan for keeping these versions up to date?
There was a problem hiding this comment.
The plan is for these to be manually updated alongside plugin releases, as they are now.
Not yet. Waiting for final 👍 on the |
This version added read-only stub properties for clientWidth, offsetWidth, etc., so we need to use Object.defineProperty to override the new default value of 0.
lucaswoj
force-pushed
the
simplify-plugins
branch
from
4919efd to
86a97a8
Compare
|
LGTM! Tiny nit but I'd make a couple spacing changes to define these groups better:
|
Todo Before Merging
|
|
Maybe as a next step, it would be cool if the script that sends the distribution file to s3, also created a version file that could be used for auto updating the version numbers here. That said, this is a great leap forward towards making releases better. Thanks! |
|
@mollymerp I finished adding deployment processes to all existing Mapbox plugins. Can you rereview? 🙏 |
|
Nice work @lucaswoj! 💪 ✨ |
|
@lucaswoj With this merged, does it make sense to remove the list in the README.md and simply point to https://www.mapbox.com/mapbox-gl-js/plugins/ ? For example the mapbox-gl-directions plugin is missing in README.md so the risk of them becoming out of sync is real. |
|
Yes @andrewharvey. That was my intention. Submitting a PR for the |
This PR closes #3947, closes #3687, and removes 74,231 lines from source control 😄
Definitely looking for feedback on the design of the plugins directory & taxonomy of plugins.
Any design suggestions @tristen @mayagao?
Related to mapbox/mapbox-gl-directions#121