Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added strict type checking to categorical style functions #4205

Merged
merged 3 commits into from
Feb 3, 2017
Merged

Added strict type checking to categorical style functions #4205

merged 3 commits into from
Feb 3, 2017

Conversation

kronick
Copy link

@kronick kronick commented Feb 3, 2017

Fixes #4174 by storing typeof from the first categorical stop. Return the default value if passed an input value of a different type.

cc @jfirebaugh for review

@jfirebaugh jfirebaugh merged commit 0f7868d into master Feb 3, 2017
@jfirebaugh
Copy link
Contributor

Thanks @kronick!

@jfirebaugh jfirebaugh deleted the strict-categorical-evaluation branch February 3, 2017 21:29
mapsam pushed a commit that referenced this pull request Feb 8, 2017
@mapsam
Added strict type checking to categorical style functions (#4205)
c0bfa3a
@jfirebaugh jfirebaugh mentioned this pull request Mar 28, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfirebaugh jfirebaugh jfirebaugh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kronick @jfirebaugh