handle error in GlyphSource#getSimpleGlyphs #3980
Conversation
js/symbol/glyph_source.js
Outdated
| if (glyph) glyphs[glyphID] = new SimpleGlyph(glyph, rect, buffer); | ||
| } | ||
| if (err) { | ||
| this.fire('error', {error: err}); |
There was a problem hiding this comment.
This is exactly how I would start 👌 .
The next step is to have the error event be propagated up to Style (from where it'll be propagated up to Map). You can see how we do this on ImageSprite here.
No error or warning is printed for missing patterns. fix mapbox#4660
We switched to 16-bit coordinates in attributes in a84083b, so there's no longer any reason to require that they are divisible by four. The integration test updates here are due to: * Underspecified behavior for overlarge text-halo-width values which was perturbed by this change * A bug in icon-text-fit logic where the width after extending mod 4 was used, instead of the intrinsic icon width * Other random and insignificant perturbations
This makes pattern usage more like icons, and will be necessary for data-driven *-pattern properties.
…ox#4688) Manually bind a_data at position 0 for symbolSDF shader. Binding unused/undefined attributes to position 0 causes symbols to not render in Safari.
* Always return image metrics exclusive of padding * Work with integer coordinates whenever possible * Eliminate redundant SpriteAtlasElement members * Fix asymmetric re-padding in getIconQuad when pixelRatio != 1 * Add explanatory comments
* fire when redoing placement so collision boxes show up when map.showCollisionBoxes is set to true * add collision box test * make render tests consistent
it was only used to find shaders (glsl) files, but it's not really needed since (1) we are using forward slashes anyway, (2) it's ignored by brfs plugin removing it stops browserify from attaching browser compliant implementation of `path` to the resulting bundle
Credit to @lamuertepeluda which provided some of the basis to this commit at mapbox#4029 (comment)
Change the "locate the user" example with better defaults for tracking a mobile user.
Switched from .npmignore to files array inside package.json - https://github.com/npm/npm/wiki/Files-and-Ignores - https://docs.npmjs.com/files/package.json
|
Hey @stepankuzmin -- I'm in the process of cleaning out our PR queue and it looks like there hasn't been any activity on this one recently. If you're still interested in coming back to it, please let us know and we'll be happy to help you get it to completion. Until then, I'm going to close it out. Thanks again for your contributions! |
|
Hi @jfirebaugh! I'm interested in completing this PR. @lucaswoj said that we need to propagate error event up to |
|
Oh, I missed that, sorry! That should be it. Can you rebase on |
|
Whoops. I'm sorry, but it seems that I made |
|
Hmm, looks kind of messy. Want to start fresh with a new PR instead? |
Is this a correct approach to #2711? Should we inherit
GlyphSourcefromEventedto fire errors?