Fix disappearing zoomed image layers #3222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucaswoj
force-pushed
the
untile-image-3010
branch
from
fff2d8c to
4383ace
Compare
jfirebaugh
approved these changes
Sep 19, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #3010 by allowing image and video sources to specify a single coordinate to the
SourceCacheto overrideTransform#coveringTiles.I strongly agree with @jfirebaugh's comment ☝️ and will be looking into refactoring per #3186 and #2291 as soon as we can get the Chattanooga release out the door.
@jfirebaugh @anandthakker @mollymerp @lbud for 👀
Launch Checklist