Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mapbox-gl-geocoder.css #343

Merged
merged 1 commit into from
Mar 17, 2020
Merged

Conversation

joewoodhouse
Copy link
Contributor

Remove weird escape character which was causing my build (when importing this file into another SASS file) to fail.

  • briefly describe the changes in this PR
  • write tests for all new functionality
  • run npm run docs and commit changes to API.md
  • update CHANGELOG.md with changes under master heading before merging

Remove weird escape character which was causing my build (when importing this file into another SASS file) to fail.
@andrewharvey
Copy link
Collaborator

@katydecorah looks like this was something you introduced, I assume just an accident and we can safely remove it?

@katydecorah
Copy link
Contributor

This was introduced in 450a567 - I believe it's a CSS hack to target certain versions of IE (ref: https://code.tutsplus.com/tutorials/quick-tip-how-to-target-ie6-ie7-and-ie8-uniquely-with-4-characters--net-10575). I think it's safe to remove, but would recommend that this branch is tested in IE to double check.

Copy link
Collaborator

@andrewharvey andrewharvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed still works and has the dotted outline on focus on IE11 so looks fine to me.

@andrewharvey
Copy link
Collaborator

The build failure is unrelated so I'll merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants