Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable proximity when reverseGeocoding #327

Merged
merged 2 commits into from
Apr 24, 2020

Conversation

andrewharvey
Copy link
Collaborator

@andrewharvey andrewharvey commented Dec 14, 2019

  • briefly describe the changes in this PR
    closes turn trackProximity off by default when reverseGeocode is true #318. Since proximity is not supported by the reverseGeocoder, this disables it if it was set by trackProximity.
  • write tests for all new functionality
  • run npm run docs and commit changes to API.md
  • update CHANGELOG.md with changes under master heading before merging

@andrewharvey andrewharvey force-pushed the 318-trackproximity-off-for-reverse-geocode branch from 48601d2 to a63ca6d Compare April 24, 2020 02:07
@andrewharvey andrewharvey merged commit f577a91 into master Apr 24, 2020
@andrewharvey andrewharvey deleted the 318-trackproximity-off-for-reverse-geocode branch April 24, 2020 02:07
@sawden
Copy link

sawden commented Apr 2, 2022

This change causes errors when reverseGeocode is enabled.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

turn trackProximity off by default when reverseGeocode is true
2 participants