Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mapbox-gl peerDependencies specification #285

Merged
merged 1 commit into from
Jul 9, 2019

Conversation

jseppi
Copy link
Contributor

@jseppi jseppi commented Jul 9, 2019

I think the way that the mapbox-gl peerDependency was specified in #280 was incorrect, as I am still getting an error during npm install:

$ npm i --save mapbox-gl@latest
npm WARN @mapbox/[email protected] requires a peer of mapbox-gl@^0.47.0 but none is installed. You must install peer dependencies yourself.

Here is what the package.json docs say:

Thus, if you’ve worked with every 1.x version of the host package, use "^1.0" or "1.x" to express this. If you depend on features introduced in 1.5.2, use ">= 1.5.2 < 2".

This PR changes the mapbox-gl peerDependency to match the format described by the above docs.

@jseppi jseppi self-assigned this Jul 9, 2019
@jseppi jseppi merged commit 46d7ca6 into master Jul 9, 2019
@jseppi jseppi deleted the fix-peer-dep-specification branch July 9, 2019 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants