Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure proximity option is passed through to request #180

Merged
merged 1 commit into from
Jan 31, 2019
Merged

ensure proximity option is passed through to request #180

merged 1 commit into from
Jan 31, 2019

Conversation

andrewharvey
Copy link
Collaborator

this fixes a regression in v3 which broke the proximity option, including a test

@andrewharvey andrewharvey requested a review from rmrice January 31, 2019 08:39
rmrice
rmrice approved these changes Jan 31, 2019
View reviewed changes
Copy link

@rmrice rmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@andrewharvey andrewharvey merged commit 148555d into master Jan 31, 2019
@andrewharvey andrewharvey deleted the fix-proximity branch January 31, 2019 23:24
@andrewharvey
Copy link
Collaborator Author

@rmrice Should we do a patch release to get this out?

@rmrice
Copy link

rmrice commented Feb 1, 2019

@andrewharvey yes, let's do that. I can roll it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmrice rmrice rmrice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewharvey @rmrice