Mitigate InfluxDB compatibility problems. #94
Conversation
Unfortunately the v1 compatibility mode of v2 doesn't work as expected in case of error messages. See e.g. influxdata/influxdb#21173 While InfluxDV v1 always shows a `error` element int the response (see https://docs.influxdata.com/influxdb/v1.3/tools/api/), v2 also emits error messages without an `error` element (see https://docs.influxdata.com/influxdb/v2.7/api/v1-compatibility/). E.g. v2 could return something like `{"code":"unprocessable entity","message":"failure writing points to database: partial write: points beyond retention policy dropped=1"}` - which currently leads to a `ClientError` exception just showing the message that the `error` key isn't present and the requested URL (which is pretty useless, since the original error message is swallowed. Therefore a small change to provide a workaround for this pretty ugly situation 😅 And for sure we all know that this is a problem of the InfluxDB - but maybe you would like to introduce this pretty small change to provide a workaround; if not, please feel free to just close this PR. And independently thanks for providing this library ❤️
|
@maoe - What's your opinion on this PR? |
|
Sorry for the delay. Did you actually test this change with InfluxDB v1 and v2? CI is failing so I wasn't sure if it's tested. |
|
As far as I remember CI failed for another/different reason - I've only tested against v2 IRL, but the change is so marginal that I couldn't image it breaks something in v1 - where according to the spec and my experience the |
Glad to hear that you've tested it against v2. I agree that this change doesn't break something in v1.
That would be great! I'm gonna merge this PR. I'd like to get the CI fixed before we make a new release on Hackage though. |
Unfortunately the v1 compatibility mode of v2 doesn't work as expected in case of error messages. See e.g. influxdata/influxdb#21173
While InfluxDB v1 always shows a
errorelement int the response (see https://docs.influxdata.com/influxdb/v1.3/tools/api/), v2 also emits error messages without anerrorelement (see https://docs.influxdata.com/influxdb/v2.7/api/v1-compatibility/).E.g. v2 could return something like
{"code":"unprocessable entity","message":"failure writing points to database: partial write: points beyond retention policy dropped=1"}- which currently leads to aClientErrorexception just showing the message that theerrorkey isn't present and the requested URL (which is pretty useless since the original error message is swallowed).Therefore a small change to provide a workaround for this pretty ugly situation 😅
And for sure we all know that this is a problem of the InfluxDB - but maybe you would like to introduce this pretty small change to provide a workaround; if not, please feel free to just close this PR.
And independently thanks for providing this library ❤️