Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#350 - don't return promise in dom-ready handler #357

Merged
merged 1 commit into from
Oct 21, 2023
Merged

#350 - don't return promise in dom-ready handler #357

merged 1 commit into from
Oct 21, 2023

Conversation

mslourens
Copy link
Contributor

@mslourens mslourens commented Oct 20, 2023 •
edited
Loading

then call is not needed to fire the promise, you just should not return anything, which will make the callback return value a void

Fixes #350

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.3) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

manusa
manusa approved these changes Oct 21, 2023
View reviewed changes
Copy link
Owner

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@manusa manusa merged commit 464c6fe into manusa:main Oct 21, 2023
@mslourens mslourens deleted the 350-tabmanager-promise-issue branch October 21, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manusa manusa manusa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tab-manager: Promise returned in function argument where a void return was expected.
2 participants
@mslourens @manusa