Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: disable dialog auto resize #128 #129

Merged
merged 1 commit into from
Oct 5, 2022
Merged

Chore: disable dialog auto resize #128 #129

merged 1 commit into from
Oct 5, 2022

Conversation

Aahil13
Copy link
Contributor

@Aahil13 Aahil13 commented Oct 4, 2022 •
edited by manusa
Loading

Fix #128

manusa
manusa requested changes Oct 4, 2022
View reviewed changes
Copy link
Owner

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for the format issues, please fix and we'll be good to go.

package.json Outdated
"name": "Marc Nuri",
"url": "https://www.marcnuri.com"
},
"author": "Marc Nuri (https://www.marcnuri.com)",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please restore the changes to the package.json or send only the one for the directories entry in a different commit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted. I will work on this ASAP

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made the necessary changes to the package.json file, as well as the formatting on the index.js and index.test.js files

@manusa manusa merged commit c6e0df9 into manusa:main Oct 5, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manusa manusa manusa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dialog auto-resize should be disabled
2 participants
@Aahil13 @manusa