Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 fix black squares in gmail #110

Merged
merged 1 commit into from
Sep 18, 2022
Merged

fix: 🐛 fix black squares in gmail #110

merged 1 commit into from
Sep 18, 2022

Conversation

sudo-tee
Copy link
Contributor

@sudo-tee sudo-tee commented Sep 18, 2022

Fix #106

Icons were displayed as black squares. the addUserAgentInterceptor was to large and I added a check for gmail

Before
image

After
image

I confirm the sign in is still possible with no "browser security check"

Icons were displayed as black squares. the addUserAgentInterceptor was to large and I added a check for gmail
@sudo-tee sudo-tee mentioned this pull request Sep 18, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

89.7% 89.7% Coverage
0.0% 0.0% Duplication

@manusa manusa self-requested a review September 18, 2022 17:39
Copy link
Owner

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@manusa manusa merged commit 8b24ea9 into manusa:main Sep 18, 2022
manusa added a commit that referenced this pull request Sep 18, 2022
@manusa manusa mentioned this pull request Sep 18, 2022
manusa added a commit that referenced this pull request Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Black squares in Gmail
2 participants