Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow @embroider/macros v1.0.0 as dependency #32

Merged
merged 1 commit into from
Jan 21, 2022
Merged

Allow @embroider/macros v1.0.0 as dependency #32

merged 1 commit into from
Jan 21, 2022

Conversation

navels
Copy link
Contributor

@navels navels commented Jan 13, 2022

@navels navels mentioned this pull request Jan 13, 2022
Closed
@navels navels changed the title Update @embroider/macos to v0.50.1 Update @embroider/macros to v0.50.1 Jan 13, 2022
@navels navels changed the title Update @embroider/macros to v0.50.1 Update @embroider/macros to v1.0.0 Jan 19, 2022
@navels
Copy link
Contributor Author

navels commented Jan 19, 2022

Now that @embroider/macros v1 is out, switching to that.

@SergeAstapov
Copy link
Contributor

@mansona would you mind to release this as patch version?

@SergeAstapov
Copy link
Contributor

@navels could you please rebase to resolve conflicts?

@navels
Copy link
Contributor Author

navels commented Jan 20, 2022

Done!

@SergeAstapov
Copy link
Contributor

@navels could you please move ember-cli-htmlbars back to devDependencies? otherwise it will cancel #33.

@navels also, could you please bump @embroider/test-setup to ^1.0.0 as well as ember-auto-import: ^2.3.0? I suspect CI would fail without these additional changes (which would sync @embroider/* packages in the deps tree).

@navels
Copy link
Contributor Author

navels commented Jan 20, 2022

Updated, thanks!

@mansona
Copy link
Owner

mansona commented Jan 21, 2022

@SergeAstapov I made a change to the dependency declaration, I wasn't comfortable bumping the dependency and doing it as a patch

and since v1 is essentially v0.50 anyway I thought being more lenient for the dependencies was a good idea 👍

@mansona mansona merged commit 53c8cf3 into mansona:master Jan 21, 2022
@mansona mansona changed the title Update @embroider/macros to v1.0.0 Allow @embroider/macros v1.0.0 as dependency Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeAstapov SergeAstapov SergeAstapov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@navels @SergeAstapov @mansona