Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump deps clap/parquet/arrow #41

Merged
merged 1 commit into from
May 5, 2023

Conversation

SteveLauC
Copy link
Contributor

What are included in this PR

  1. Bump parquet/arrow to 38.0.0

  2. Bump clap to 4.2.7

  3. In parquet, ArrowReader and ParquetFileArrowReader are deprecated and replaced with ArrowReaderBuilder and ParquetRecordBatchReaderBuilder

  4. In clap, multiple_values = true is replaced with num_args = 1..

  5. Use #[arg(short, long)] instead of #[clap(short, long)]

  6. The behavior of record_batch_to_json_row() has been changed and thus our integration test for pqrs cat --json needs to be changed too(CAT_JSON_OUTPUT needs to be updated)

    # old output
    $ pqrs cat data/cities.parquet --json
    
    #########################
    File: data/cities.parquet
    #########################
    
    {"continent":"Europe","country":{"name":"France","city":["Paris","Nice","Marseilles","Cannes"]}}
    {"continent":"Europe","country":{"name":"Greece","city":["Athens","Piraeus","Hania","Heraklion","Rethymnon","Fira"]}}
    {"continent":"North America","country":{"name":"Canada","city":["Toronto","Vancouver","St. John's","Saint John","Montreal","Halifax","Winnipeg","Calgary","Saskatoon","Ottawa","Yellowknife"]}}
    
    # new output
    $ ./target/debug/pqrs cat data/cities.parquet --json
    
    #########################
    File: data/cities.parquet
    #########################
    
    {"continent":"Europe","country":{"city":["Paris","Nice","Marseilles","Cannes"],"name":"France"}}
    {"continent":"Europe","country":{"city":["Athens","Piraeus","Hania","Heraklion","Rethymnon","Fira"],"name":"Greece"}}
    {"continent":"North America","country":{"city":["Toronto","Vancouver","St. John's","Saint John","Montreal","Halifax","Winnipeg","Calgary","Saskatoon","Ottawa","Yellowknife"],"name":"Canada"}}
    
    
  7. code format with cargo fmt

@SteveLauC
Copy link
Contributor Author

Since this is the successor of #32, let's close it.
Closes #32

@manojkarthick
Copy link
Owner

This looks great! Thanks a lot making these updates @SteveLauC - really appreciate it!

@manojkarthick manojkarthick merged commit e9ee652 into manojkarthick:master May 5, 2023
@SteveLauC SteveLauC deleted the dep branch May 5, 2023 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants