webpack init #1
Merged
webpack init #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IrinaStoetski
approved these changes
Sep 20, 2021
ygorbunkov
reviewed
Sep 21, 2021
package.json
Outdated
| "description": "", | ||
| "private": true, | ||
| "scripts": { | ||
| "dev": "cross-env NODE_ENV=development webpack-dev-server --mode development --open", |
There was a problem hiding this comment.
You should bear in mind that cross-env is no longer developed, which may be the reason of its declined popularity, so you may opt for corresponding command-line parameter, consider alternative solution or expose webpack config as a function and pass current mode as a command line parameter.
ygorbunkov
reviewed
Sep 21, 2021
webpack.config.js
Outdated
| splitChunks: { | ||
| // chunks: "all", | ||
| cacheGroups: { | ||
| commons: { |
There was a problem hiding this comment.
Doesn't, probably, make much sense for development mode.
ygorbunkov
reviewed
Sep 21, 2021
webpack.config.js
Outdated
| { from: "static", to: "static" } | ||
| ], | ||
| }), | ||
| new MiniCssExtractPlugin({ |
There was a problem hiding this comment.
You, probably, shouldn't even include this in development mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.