-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When I seek to just before the end, PLAYBACK_COMPLETE event does not fire #473
Comments
Mangui, we're seeing this as well when we upgraded to 0.4.4.16. Our automated tests started failing on several of our test medias. There appears to be a strange hitch at the end of the media that we've never noticed before. We get a series of MediaPlayerStateChange events: buffering, playing, ready, then the PLAYBACK_COMPLETE event is fired directly. The issue is that sometimes (it seems to be when the last fragment isn't cached?) the state gets stuck on buffering and never recovers. I put in a timer to close things down when it stalls, but I'm hoping that's temporary. Here's some of the media we're seeing the "hitch" on: http://delivery.support.theplatform.com/pdk_qa/PDK_(VMS)/928/739/Batman_v_Superman-_Dawn_of_Justice_-_Comic-Con_Trailer_[HD]_(720p).m3u8 Merci beaucoup, Daniel Niland |
We found the same issue, where playback gets stuck on buffering, could happen during seeks in the middle of the media. We had to roll back to our prior forked version. |
Hi Daniel. Will check on monday |
Hi @zawao |
…ted PTS is above max PTS when level switch-down occurs after the loading of last fragment, playback complete was not fired appropriately, leading to flashls staying stuck on buffering state at the end of the playback. related to #473
Hi @mangui When the playback is finished, it may to occur values of "current level" and "load level" are different? |
ok I was able to reproduce similar issue with @dtniland stream. this logic is there since a while (does not look like a regression) |
plz recheck with latest flashls/dev, and tell me how it behaves now |
@mangui we had been using a fork of 0.4.2.3 or so. I'll check it today. Thanks for the quick fix! |
Unfortunately, it looks like there is still an issue. You have fixed the issue with the last fragment -- our tests no longer hang there. But, we're also seeing the same issue in the middle of the media. Our system dynamically inserts ads from the server by creating a discontinuity. We're seeing the buffer not returning when we seek to the exact spot of this continuity. Strangely, it is only an issue on Windows Chrome -- it could have something to do with caching? Our system can only be accessed via a token that expires in seconds so it isn't possible to give you a link to the manifest directly. I'm attaching the manifest files as they've been downloaded by the browser and hopefully you can look at them to figure out what's going on. In this particular media, we're seeking to 114.0 seconds. In OSMF, we get a MediaPlayerStateChange of buffering, then an onSeekChange with seeking = true, then we call play(). At that point the media never goes to the the playing state. If this isn't enough to know what's going on, let me know... we'll try to work something out. Thanks! dtniland |
Hi @dtniland |
Hi @mangui Thanks! |
@mangui We have a repro that you can hit. In http://www.flashls.org/latest/examples/osmf/StrobeMediaPlayback.html go the js console and type in:
hit the play button then in the js console:
We have reproed the buffering message spinning forever. |
ok will check next week |
thanks, @mangui. |
if requested PTS is bigger than any PTS in this continuity counter range and if this is not the last continuity range of this playlist, then matching Sequence Number is the first one of following continuity range, i.e last frag.seqnum + 1 related to #473
@dtniland you can recheck with latest flashls/dev, issue should be fixed |
@mangui, your fix worked perfectly -- we're not seeing the issue any more. Thanks! |
I seek to just before the end of the video. And the video is completed.
However, PLAYBACK_COMPLETE event does not fire.
Playback state stops at PLAYING_BUFFERING.
This problem occurs in the sample player.
http://www.flashls.org/latest/examples/chromeless/
The text was updated successfully, but these errors were encountered: