Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLSEvent.MEDIA_TIME don't pass correct program_date. #293

Closed
alf-ytakada opened this issue Jun 2, 2015 · 2 comments
Closed

HLSEvent.MEDIA_TIME don't pass correct program_date. #293

alf-ytakada opened this issue Jun 2, 2015 · 2 comments
Labels

Comments

@alf-ytakada
Copy link

Hi @mangui !

I need to use program_date, but HLSEvent.MEDIA_TIME event's HLSPlayMetrics instance has wrong program_datetime.

I fixed below code.
https://github.com/mangui/flashls/blob/dev/src/org/mangui/hls/model/Fragment.as#L67-L68
like this.

        data.writeObject(this.duration);
        data.writeObject(1);  // added. 
        data.writeObject(this.program_date);

and now it works!

Please check it.

Regards,

mangui added a commit that referenced this issue Jun 2, 2015
fix invalid metrics value : program_date and audio_only field were wrongly permuted.
related to #293
@mangui
Copy link
Owner

mangui commented Jun 2, 2015

@alf-ytakada thanks for reporting, your fix is fixing program date time but it will break other fields :-)
plz check with latest flashls/dev and let me know how it behaves now

@mangui mangui added the bug label Jun 2, 2015
@alf-ytakada
Copy link
Author

@mangui Thanks for your response.
I merged dev branch and confirmed the issue has been fixed.

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants