feat!(amplifier): Return both transaction and result promises #1853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
espendk
force-pushed
the
feat/amplifier-fix
branch
from
a3aea22 to
92f7034
Compare
anasbelbaz
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes the test errors introduced in cef83d0
Unrelatedly, the latest forge (
0.2.0 (7545c7a 2024-03-12T00:17:55.654014000Z)) breaks two tests withMemoryLimitOOG:CoreKandelInstance integration tests suite->CoreKandelInstance integration tests suiteRestingOrder->update tickSpacing=100 resting buy orderThis should IMO not keep this PR from being merged; We'll should handle that issue separately (hopefully, it'll be fixed in the next nightly).