Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to new Mangrove Order #1713

Merged
merged 45 commits into from
Jan 22, 2024
Merged

Update to new Mangrove Order #1713

merged 45 commits into from
Jan 22, 2024

Conversation

maxencerb
Copy link
Contributor

@maxencerb maxencerb commented Jan 10, 2024

TODO list:

  • Match the new function signatures of Mangrove order
  • Add deploy aave logic on deploy script
  • Add resting order gas req dependant on logic
  • Add test for aave logic
  • Add setRouteLogic for an offer
  • Provide a set of strats out of the box

Copy link
Contributor

@espendk espendk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

Added some smaller comments.

Copy link
Contributor

@lnist lnist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, very good work @maxencerb! General disclaimer: I do not have deep knowledge of the new strat contracts, so I cannot determine if all the necessary changes due to new strat contracts have been made, so I assume you are on top of that.

Copy link
Contributor

@espendk espendk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements 👌

As you're off, I've taken the liberty of pushing some very minor adjustments, so we can get this merged and published.

@espendk espendk enabled auto-merge (squash) January 22, 2024 08:36
@espendk espendk requested a review from DanielRX January 22, 2024 08:45
@espendk espendk merged commit 3fb4f08 into develop Jan 22, 2024
1 check passed
@espendk espendk deleted the feat/smartRouter branch January 22, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants