-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Use addresses from mangrove-deployments and context-addresses packages #1579
Merged
espendk
merged 10 commits into
develop
from
feat/move-addresses-to-mangrove-deployments
Nov 15, 2023
Merged
feat: Use addresses from mangrove-deployments and context-addresses packages #1579
espendk
merged 10 commits into
develop
from
feat/move-addresses-to-mangrove-deployments
Nov 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kage This is a first version that simply loads addresses from the latest deployments regardless of version or release status.
Query mangrove-deployments for deployments matching the installed mangrove-core and mangrove-strats packages or patches of these.
This is a first version that only loads default tokens and associates them with the token symbol.
espendk
force-pushed
the
feat/move-addresses-to-mangrove-deployments
branch
from
November 10, 2023 15:45
9ec67e8
to
b691cff
Compare
espendk
changed the title
Use deployed addresses from mangrove-deployments package
Use addresses from mangrove-deployments and context-addresses packages
Nov 10, 2023
Instead of the ambiguous token symbols use the instance ID's assigned by context-addresses. This makes all token instances available and enforces clarity on which ERC20 instance one is interacting with. To ease the transition, the default instances are still available using just the token symbol as identifier. However, use of this is deprecated.
espendk
force-pushed
the
feat/move-addresses-to-mangrove-deployments
branch
from
November 11, 2023 09:03
a48ac5b
to
a4d96f5
Compare
espendk
force-pushed
the
feat/move-addresses-to-mangrove-deployments
branch
from
November 13, 2023 16:33
f8934f0
to
be7e313
Compare
espendk
force-pushed
the
feat/move-addresses-to-mangrove-deployments
branch
from
November 14, 2023 16:55
55a4554
to
104103f
Compare
dontrolle
suggested changes
Nov 15, 2023
dontrolle
approved these changes
Nov 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌴
espendk
changed the title
Use addresses from mangrove-deployments and context-addresses packages
feat: Use addresses from mangrove-deployments and context-addresses packages
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a first improvement to the deployment process: It moves context addresses out of this repo and instead reads addresses from these new repos/npm packages:
See the companion PR's in
mangrove-core
andmangrove-strats
for more details:Brief solution overview
The configuration loading logic has been changed to load addresses from the above npm packages instead of from
mangrove-core
,mangrove-strats
, and theaddresses.json
file.When querying
mangrove-deployments
for deployment addresses, one must specify the contract version and whether the deployment is of a "released" version.configuration.ts
queries for contract versions matching patches of the package versions listed inpackage.json
formangrove-core
andmangrove-strats
, regardless of whether they are released. Later, we may wish to provide a way for clients to control this behaviour.