Proposal: Add implicit flow through popup #468
Conversation
|
The corresponding html for the iframe needs to be changed to consider <html>
<body>
<script>
(window.opener || window.parent).postMessage(location.hash, location.origin);
</script>
</body>
</html> |
|
👍 LGTM, nice feature! (Disclaimer: haven't tested it though, just skimmed through the changes.) |
|
Tested it by copying it to my project, as we require this functionality at short notice. The implementation works well. It does require modifying the silent-refresh.html as per @leonardochaia's comment. Also, you may want to modify the All in all, nice job! Saved me a lot of time. 👍 |
|
@manfredsteyer is there any reason this shouldnt be merged? |
|
Great. THX! |
|
Is this feature documented somewhere? |
|
Hi @pieterdb4477, unfortunately it's not.
<html>
<body>
<script>
(window.opener || window.parent).postMessage(location.hash, location.origin);
</script>
</body>
</html>
Regards, |
|
The problem I am facing is I don't know what to do after system finished popup flow. I have tried this out but nothing return.
What if I clear local storage then refresh browser. The flow still shows popup but there is something wrong in local storage. Here it is:
Regard, |
|
hey @lamnv5490 , if I remember correctly after you've called I'm did not understand the last part of your comment tho. |
|
The last part happened when I delete all local storage and press F5 button. The popup still shows up but I didn't get any access token. I know that when the popup closes, I would able to get the token. But it would be great that we could observe our |
This PR adds a new method
initImplicitFlowInPopupwhich opens a newWindowto thesilentRefreshRedirectUriwith thedisplay=popupquery param.It performs the implicit flow inside the popup, inspired on how silent renewal is being done.