Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add get http query uri #714

Merged
merged 4 commits into from
Feb 28, 2023
Merged

add get http query uri #714

merged 4 commits into from
Feb 28, 2023

Conversation

williballenthin
Copy link
Collaborator

@williballenthin williballenthin commented Feb 26, 2023

ref #3

please LINT_THOROUGH

@williballenthin williballenthin added the enhancement New feature or request label Feb 26, 2023
communication/http/get-http-query-uri.yml Outdated Show resolved Hide resolved
@@ -0,0 +1,15 @@
rule:
meta:
name: get HTTP query URI
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about "query"... How about request or header?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tbh, i misunderstood what this HttpQueryInfo option fetched. i thought it was the query parameters portion of the URL, but i see now its the whole URL. so i'd propose:

get HTTP request URL

@mr-tz
Copy link
Collaborator

mr-tz commented Feb 28, 2023

Hm, the linter should have run thoroughly before. Maybe there's a 13 in the block as well?

Copy link
Collaborator

@mr-tz mr-tz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😃 cool

@williballenthin williballenthin merged commit 274d72e into master Feb 28, 2023
@williballenthin williballenthin deleted the http-query-uri branch February 28, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants