Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve rules that often match #655

Merged
merged 5 commits into from
Jan 9, 2023
Merged

improve rules that often match #655

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5231809
improve rules that often match
mr-tz Jan 6, 2023
0256ab0
this is now a library rule
mr-tz Jan 6, 2023
63cee01
Update lib/calculate-modulo-256-via-x86-assembly.yml
mr-tz Jan 9, 2023
b03e82d
Update lib/calculate-modulo-256-via-x86-assembly.yml
mr-tz Jan 9, 2023
262a55c
Apply suggestions from code review
mr-tz Jan 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion executable/resource/extract-resource-via-kernel32-functions.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,3 @@ rule:
- api: LdrFindResourceEx_U
- api: kernel32.SizeofResource
- api: kernel32.FreeResource
- api: user32.LoadString
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that's really what we are after normally. Anyone thing it's worth creating a new rule for it?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree that this should be removed

17 changes: 0 additions & 17 deletions host-interaction/process/terminate/terminate-process-via-fastfail.yml
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion .../registry/create-or-open-registry-key.yml → lib/create-or-open-registry-key.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
rule:
meta:
name: create or open registry key
namespace: host-interaction/registry
authors:
- [email protected]
- [email protected]
lib: true
scope: basic block
mbc:
- Operating System::Registry::Create Registry Key [C0036.004]
Expand Down