Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "dist: Remove support for building and distributing *.egg files" #135

Merged
merged 1 commit into from
May 28, 2019
Merged

Revert "dist: Remove support for building and distributing *.egg files" #135

merged 1 commit into from
May 28, 2019

Conversation

jcfr
Copy link
Contributor

@jcfr jcfr commented Mar 21, 2019

This reverts commit dd239fd.

@jcfr
Copy link
Contributor Author

jcfr commented Mar 21, 2019

cc: @eeaston

@jcfr jcfr mentioned this pull request Mar 21, 2019
Merged
@jcfr jcfr force-pushed the restore-2.7-eggs-building branch from 80be7fa to c72a778 Compare March 21, 2019 15:57
@jcfr jcfr force-pushed the restore-2.7-eggs-building branch from c72a778 to b2b3b9c Compare March 21, 2019 16:16
@bmoscon bmoscon requested review from eeaston and bmoscon March 21, 2019 20:07
@jcfr
Copy link
Contributor Author

jcfr commented May 22, 2019

Dear project maintainers,

Would be awesome to move forward with integrating this PR and do a new release of the plugins on pypi 😄

Let me know if there is anything I could to help,

Thanks,

@bmoscon
Copy link
Collaborator

bmoscon commented May 22, 2019

@eeaston looks good to merge to me, does this work for the eggs you needed built?

@eeaston eeaston merged commit e58de69 into man-group:master May 28, 2019
@jcfr
Copy link
Contributor Author

jcfr commented May 28, 2019

Thanks for merging 🙏

@eeaston
Copy link
Collaborator

eeaston commented May 28, 2019

No problems - very sorry for the massive delay on these! I'm running through all the PRs and getting a release out asap.

@jcfr
Copy link
Contributor Author

jcfr commented May 28, 2019

Sounds good. And thanks for getting to it, I just did my due diligence of pinging the issue few days ago 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmoscon bmoscon bmoscon approved these changes

@eeaston eeaston Awaiting requested review from eeaston

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jcfr @bmoscon @eeaston