Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

解决最后一个mirai码之后的消息无法解析的问题 #431

Closed
wants to merge 8 commits into from
Closed

解决最后一个mirai码之后的消息无法解析的问题 #431

wants to merge 8 commits into from

Conversation

CHMing7
Copy link
Contributor

@CHMing7 CHMing7 commented Jul 11, 2020

No description provided.

@Him188
Copy link
Member

Him188 commented Jul 11, 2020 •
edited
Loading

感谢发现并解决这个问题, 我们会添加相关测试并在测试通过后合并这个 PR

@Him188 Him188 self-assigned this Jul 11, 2020
@Him188 Him188 added M 优先级: 主要 t:bug 类型: bug labels Jul 11, 2020
@Him188 Him188 added this to the 1.2.0 milestone Jul 11, 2020
@Him188 Him188 removed their assignment Jul 11, 2020
@CHMing7
Copy link
Contributor Author

CHMing7 commented Jul 11, 2020

感谢发现并解决这个问题, 我们会添加相关测试并在测试通过后合并这个 PR

经过一系列测试，最新代码改动如下：
if (lastIndex != this.length) {
block(substring(lastIndex, this.length), null, "")
}

@Him188
Copy link
Member

Him188 commented Jul 11, 2020

感谢发现并解决这个问题, 我们会添加相关测试并在测试通过后合并这个 PR

经过一系列测试，最新代码改动如下：
if (lastIndex != this.length) {
block(substring(lastIndex, this.length), null, "")
}

请直接提交修改

Him188 added a commit that referenced this pull request Jul 11, 2020
@Him188
mirai code: Add tests for the message after last message element (#431)
87eb212
Him188 pushed a commit that referenced this pull request Jul 11, 2020
@Him188
Fix #431
1d0c3c2
Him188 added a commit that referenced this pull request Jul 11, 2020
@Him188
mirai code: Add tests for the message after last message element (#431)
d6b85d4
@Him188 Him188 closed this in 2337453 Jul 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
M 优先级: 主要 t:bug 类型: bug
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@CHMing7 @Him188 @only52607