-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[console] Pre check plugin duplication & console requirement #2703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cssxsh
commented
Jun 21, 2023
mirai-console/backend/mirai-console/src/plugin/jvm/JvmPluginDescription.kt
Outdated
Show resolved
Hide resolved
consoleRequirement 方法似乎是多余的, dependsOn 已经能表示 console require 了吧 |
dependsOn 有多个同名函数,适合拓展 console version 判断的只有 (必须指定 versionRequirement)
而且参数名已经敲定了 pluginId |
dependsOn 是最符合直觉也可以直接扩展的,没人规定不能存在特殊值,plugin id 可以把 |
Him188
requested changes
Jul 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
另外看起来没有支持 YAML 加载
mirai-console/backend/mirai-console/src/plugin/description/PluginDescription.kt
Outdated
Show resolved
Hide resolved
mirai-console/backend/mirai-console/src/plugin/jvm/JvmPluginDescription.kt
Outdated
Show resolved
Hide resolved
70a8465
to
52b39d7
Compare
52b39d7
to
b6e0f5e
Compare
Him188
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check id in load plugin
close 插件ID冲突时,应在插件初始化之前就将冲突插件排除 #2136
console requirement
close 在 JvmPluginDescription 中 添加对 mirai-console 版本的判断 #1895
Extra: Wrap console as plugin instance into loaded plugins