Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move org.slf4j.spi.SLF4JServiceProvider #2701

Merged
merged 2 commits into from
Jul 26, 2023
Merged

move org.slf4j.spi.SLF4JServiceProvider #2701

merged 2 commits into from
Jul 26, 2023

Conversation

cssxsh
Copy link
Contributor

@cssxsh cssxsh commented Jun 21, 2023

close #2443

@Him188 Him188 requested a review from Karlatemp June 25, 2023 09:59
@Karlatemp
Copy link
Member

mirai-console self test source 也需要

@cssxsh
Copy link
Contributor Author

cssxsh commented Jun 30, 2023

mirai-console self test source

意思是我要修改相关测试还是 新写一个测试？

@Karlatemp
Copy link
Member

意思是console test也要放一个service文件

@cssxsh
Copy link
Contributor Author

cssxsh commented Jul 5, 2023

意思是console test也要放一个service文件

mirai-console/backend/integration-test 依赖了:mirai-console-frontend-base

mirai-console/backend/mirai-console/test 的结构看不懂，不知道该放在那

@Karlatemp
Copy link
Member

mirai-console/backend/mirai-console/testRes 或者是 testResource, 看 idea 补全吧

@Karlatemp Karlatemp added N 优先级: 一般 t:task 类型: 要做的任务 s:console 子系统: mirai-console labels Jul 5, 2023
@Karlatemp Karlatemp added this to the 2.16.0-RC milestone Jul 5, 2023
@Karlatemp Karlatemp added the z:ready-to-merge 状态: PR 已经可以合并, 正在等待一些安排 label Jul 10, 2023
@Karlatemp Karlatemp merged commit 5ace423 into mamoe:dev Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Karlatemp Karlatemp Karlatemp approved these changes

Assignees
No one assigned
Labels
N 优先级: 一般 s:console 子系统: mirai-console t:task 类型: 要做的任务 z:ready-to-merge 状态: PR 已经可以合并, 正在等待一些安排
Projects
None yet
Milestone
2.16.0-RC
Development

Successfully merging this pull request may close these issues.

建议将 mirai-console (backend) 中 org.slf4j.spi.SLF4JServiceProvider 文件 移动至 移动至 frontend
2 participants
@cssxsh @Karlatemp