Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OnlinePush.SidTicketExpired logic #2563

Merged
merged 2 commits into from
Mar 21, 2023
Merged

Fix OnlinePush.SidTicketExpired logic #2563

merged 2 commits into from
Mar 21, 2023

Conversation

sandtechnology
Copy link
Collaborator

No description provided.

@Karlatemp Karlatemp added x:protocol 属性: 协议相关 s:core 子系统: mirai-core labels Mar 11, 2023
@Him188
Copy link
Member

Him188 commented Mar 21, 2023

为什么?

@sandtechnology
Copy link
Collaborator Author

为什么?

这个只是一个服务器告知进行刷新web token操作的包（触发客户端web token主动刷新） 客户端只需要回复服务器并在本地用拿到的新token更新即可 并不需要重新登录 而mirai已经完成了这一行为 所以直接去除先前错误加入的逻辑即可

@sandtechnology
Copy link
Collaborator Author

哦忘记写回包逻辑了 稍等一下我加上

@Him188
Copy link
Member

Him188 commented Mar 21, 2023

草, mirai 在哪刷新的 token, 我怎么不记得有写

@Him188 Him188 added this to the 2.15.0-RC milestone Mar 21, 2023
@sandtechnology
Copy link
Collaborator Author

草, mirai 在哪刷新的 token, 我怎么不记得有写

on login success pt4那堆就是

@sandtechnology
Copy link
Collaborator Author

哦 这个函数已经带上了 所以这样写是可以的 不需要上逻辑 如果没问题的话可以直接merge（

@sandtechnology
Copy link
Collaborator Author

然后发现一直都漏了个commandName 加上了就ok了（草

@Him188
Copy link
Member

Him188 commented Mar 21, 2023

服务器告知刷新是发来什么包?

@sandtechnology
Copy link
Collaborator Author

sandtechnology commented Mar 21, 2023 •
edited
Loading

服务器告知刷新是发来什么包?

发送和回复都是 OnlinePush.SidTicketExpired

@Him188
Copy link
Member

Him188 commented Mar 21, 2023

可是这个不会触发 mirai 去更新吧, 如果你删了现有这个

@sandtechnology
Copy link
Collaborator Author

可是这个不会触发 mirai 去更新吧, 如果你删了现有这个

这个是在服务器发送了更新过的token（比如说你进行了快速登录） 后服务器发送的主动触发客户端更新web token的一个包
也就是说 在登录流程token发过来之后 服务器主动要求客户端从本地的服务拉取token来进行token的更新的一个包（更新官方QQ内置浏览器那边的token）
mirai在登录流程中本来就会自动进行更新 所以不需要进行额外操作（https://github.com/mamoe/mirai/blob/c016b822e765161a37c372c7138adc88b8377e26/mirai-core/src/commonMain/kotlin/network/protocol/packet/login/WtLogin.kt#L546-L547）
虽然说不知道为什么特地设置了这个 但是他确实就是这样的（而且还重复发了几次确保更新到位
可能是屎山吧（

@Him188
Copy link
Member

Him188 commented Mar 21, 2023

草

@Him188 Him188 merged commit 7e20883 into mamoe:dev Mar 21, 2023
@sandtechnology sandtechnology mentioned this pull request Mar 21, 2023
Merged
StageGuard pushed a commit to StageGuard/mirai that referenced this pull request Apr 14, 2023
@sandtechnology
[core] Fix OnlinePush.SidTicketExpired logic (mamoe#2563)
5be368d 
* Fix OnlinePush.SidTicketExpired logic

* Add missed responseCommandName
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
s:core 子系统: mirai-core x:protocol 属性: 协议相关
Projects
None yet
Milestone
2.15.0-RC
Development

Successfully merging this pull request may close these issues.
3 participants
@sandtechnology @Him188 @Karlatemp