-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: essence message setting #2314
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Karlatemp
reviewed
Dec 17, 2022
mirai-core-api/src/commonMain/kotlin/contact/essence/EssenceMessageRecord.kt
Outdated
Show resolved
Hide resolved
mirai-core-api/src/commonMain/kotlin/contact/essence/Essences.kt
Outdated
Show resolved
Hide resolved
mirai-core/src/jvmBaseMain/kotlin/contact/essence/EssencesImpl.kt
Outdated
Show resolved
Hide resolved
Him188
reviewed
Dec 27, 2022
mirai-core-api/src/commonMain/kotlin/contact/essence/Essences.kt
Outdated
Show resolved
Hide resolved
mirai-core-api/src/commonMain/kotlin/contact/essence/Essences.kt
Outdated
Show resolved
Hide resolved
mirai-core-api/src/commonMain/kotlin/contact/essence/Essences.kt
Outdated
Show resolved
Hide resolved
mirai-core-api/src/commonMain/kotlin/contact/essence/Essences.kt
Outdated
Show resolved
Hide resolved
mirai-core-api/src/commonMain/kotlin/contact/essence/Essences.kt
Outdated
Show resolved
Hide resolved
mirai-core-api/src/commonMain/kotlin/contact/essence/Essences.kt
Outdated
Show resolved
Hide resolved
mirai-core-api/src/commonMain/kotlin/contact/essence/Essences.kt
Outdated
Show resolved
Hide resolved
mirai-core/src/jvmBaseMain/kotlin/contact/essence/EssencesImpl.kt
Outdated
Show resolved
Hide resolved
cssxsh
commented
Feb 19, 2023
mirai-core/src/commonMain/kotlin/contact/essence/EssencesImpl.kt
Outdated
Show resolved
Hide resolved
# Conflicts: # mirai-core-mock/src/internal/contact/MockGroupImpl.kt # mirai-core/src/commonMain/kotlin/contact/GroupImpl.kt
Karlatemp
reviewed
Feb 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 如果同时有直接协议通道和 web 通道, 是不是直接协议通道更好
- 修改
Group.setEssenceMessage
使用相同的通道
Him188
reviewed
Mar 1, 2023
mirai-core-api/src/commonMain/kotlin/contact/essence/EssenceMessageRecord.kt
Outdated
Show resolved
Hide resolved
用PB通道确实应该更稳定吧, 可以优先协议, 失败了就 web? |
Him188
reviewed
Mar 19, 2023
mirai-core/src/commonMain/kotlin/contact/essence/EssencesImpl.kt
Outdated
Show resolved
Hide resolved
Him188
approved these changes
Mar 21, 2023
mirai-core/src/commonMain/kotlin/contact/essence/EssencesImpl.kt
Outdated
Show resolved
Hide resolved
Him188
approved these changes
Mar 21, 2023
StageGuard
pushed a commit
to StageGuard/mirai
that referenced
this pull request
Apr 14, 2023
* feat: remove essence message * feat: Essences * add: share and remove * fix: impl * fix: arguments * feat: image url to image * add: doc * fix: doc * Copyright: 2023 * remove: method removeEssenceMessage * feat: lazy load source * add: no parse * add: sendAndExpect try * fix: remove throw * fix: parse IMAGE_MD5_REGEX
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
s:core
子系统: mirai-core
t:feature
类型: 新特性
x:protocol
属性: 协议相关
z:ready-to-merge
状态: PR 已经可以合并, 正在等待一些安排
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #837, close #2293
另外还有 从 http api 读取 essence message list 的 api 还没写完