Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: essence message setting #2314

Merged
merged 19 commits into from
Mar 21, 2023
Merged

feat: essence message setting #2314

merged 19 commits into from
Mar 21, 2023

Conversation

cssxsh
Copy link
Contributor

@cssxsh cssxsh commented Oct 29, 2022

close #837, close #2293

另外还有 从 http api 读取 essence message list 的 api 还没写完

@cssxsh cssxsh marked this pull request as draft October 29, 2022 10:01
@cssxsh cssxsh changed the title feat: remove essence message feat: essence message setting Oct 29, 2022
@cssxsh cssxsh marked this pull request as ready for review December 17, 2022 21:37
@Him188 Him188 self-requested a review December 17, 2022 22:43
@Him188 Him188 added this to the 2.14.0-RC milestone Dec 17, 2022
@Him188 Him188 requested a review from Karlatemp December 17, 2022 22:44
@Him188 Him188 added t:feature 类型: 新特性 x:protocol 属性: 协议相关 s:core 子系统: mirai-core labels Dec 17, 2022
@cssxsh cssxsh requested a review from Him188 January 5, 2023 02:09
@Karlatemp Karlatemp modified the milestones: 2.14.0-RC, 2.15 Jan 18, 2023
@Him188 Him188 modified the milestones: 2.15, 2.15.0-RC Jan 18, 2023
# Conflicts:
#	mirai-core-mock/src/internal/contact/MockGroupImpl.kt
#	mirai-core/src/commonMain/kotlin/contact/GroupImpl.kt
Copy link
Member

@Karlatemp Karlatemp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. 如果同时有直接协议通道和 web 通道, 是不是直接协议通道更好
  2. 修改 Group.setEssenceMessage 使用相同的通道

@Him188
Copy link
Member

Him188 commented Mar 1, 2023

用PB通道确实应该更稳定吧, 可以优先协议, 失败了就 web?

@Him188 Him188 added the z:ready-to-merge 状态: PR 已经可以合并, 正在等待一些安排 label Mar 21, 2023
@Him188 Him188 merged commit f4fa2ca into mamoe:dev Mar 21, 2023
StageGuard pushed a commit to StageGuard/mirai that referenced this pull request Apr 14, 2023
* feat: remove essence message

* feat: Essences

* add: share and remove

* fix: impl

* fix: arguments

* feat: image url to image

* add: doc

* fix: doc

* Copyright: 2023

* remove: method removeEssenceMessage

* feat: lazy load source

* add: no parse

* add: sendAndExpect try

* fix: remove throw

* fix: parse IMAGE_MD5_REGEX
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s:core 子系统: mirai-core t:feature 类型: 新特性 x:protocol 属性: 协议相关 z:ready-to-merge 状态: PR 已经可以合并, 正在等待一些安排
Projects
None yet
Development

Successfully merging this pull request may close these issues.

希望能够添加群精华消息的Event QQ机器人获取和设置群精华消息
3 participants