Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add: 石头剪刀布 表情 #2220

Merged
merged 3 commits into from
Jan 3, 2023
Merged

add: 石头剪刀布 表情 #2220

merged 3 commits into from
Jan 3, 2023

Conversation

cssxsh
Copy link
Contributor

@cssxsh cssxsh commented Aug 27, 2022

No description provided.

@Karlatemp Karlatemp added the s:core 子系统: mirai-core label Aug 29, 2022
@Him188 Him188 added t:feature 类型: 新特性 x:protocol 属性: 协议相关 labels Sep 1, 2022
@Him188 Him188 added this to the 2.14 milestone Sep 1, 2022
@Him188 Him188 modified the milestones: 2.14, 2.14.0-RC Sep 23, 2022
Him188
Him188 reviewed Sep 23, 2022
View reviewed changes
Copy link
Member

@Him188 Him188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

请在 MarketFaceProtocolTest (应该叫这个名字) 添加相关测试 (解码, 编码, 序列化)

可参考 文档 或 MarketFaceProtocolTest 中的已有测试

@Karlatemp Karlatemp requested a review from Him188 December 18, 2022 06:21
@Karlatemp Karlatemp self-assigned this Dec 18, 2022
@Karlatemp Karlatemp requested a review from Him188 December 27, 2022 16:35
@Him188 Him188 added the z:ready-to-merge 状态: PR 已经可以合并, 正在等待一些安排 label Jan 2, 2023
@Karlatemp Karlatemp merged commit 2cffb7a into mamoe:dev Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Him188 Him188 Him188 approved these changes

Assignees

@Karlatemp Karlatemp

Labels
s:core 子系统: mirai-core t:feature 类型: 新特性 x:protocol 属性: 协议相关 z:ready-to-merge 状态: PR 已经可以合并, 正在等待一些安排
Projects
None yet
Milestone
2.14.0-RC
Development

Successfully merging this pull request may close these issues.
3 participants
@cssxsh @Him188 @Karlatemp