Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OtherClientCommandSenderOnMessageSync #2085

Merged
merged 2 commits into from
Aug 3, 2022
Merged

Add OtherClientCommandSenderOnMessageSync #2085

merged 2 commits into from
Aug 3, 2022

Conversation

Him188
Copy link
Member

@Him188 Him188 commented Jun 8, 2022

No description provided.

@Him188 Him188 added t:feature 类型: 新特性 s:console 子系统: mirai-console s:core 子系统: mirai-core x:deprecation 属性: API 弃用 labels Jun 8, 2022
@Him188 Him188 added this to the 2.12.0-RC milestone Jun 8, 2022
@Him188 Him188 force-pushed the other-client-command-sender-on-message-sync branch from 0a8fc34 to 903697e Compare June 14, 2022 08:54
@Him188 Him188 marked this pull request as ready for review June 15, 2022 08:52
@Him188 Him188 requested a review from Karlatemp June 15, 2022 11:39
Karlatemp
Karlatemp reviewed Jun 15, 2022
View reviewed changes
Copy link
Member

@Karlatemp Karlatemp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

新的command sender的permitee id是什么，又是否会因为在群聊 / 私聊改变 pid

@Him188
Copy link
Member Author

Him188 commented Jun 15, 2022

@Karlatemp 确实，没考虑

@Him188
Copy link
Member Author

Him188 commented Jun 18, 2022

@Karlatemp 继承 OtherClientCommandSender 的 PID，AbstractPermitteeId.AnyOtherClient，我觉得行

@Him188 Him188 modified the milestones: 2.12.0-RC, 2.13, 2.13.0-RC Jun 18, 2022
@Karlatemp Karlatemp linked an issue Jun 18, 2022 that may be closed by this pull request
添加对应于 MessageSyncEvent 的 CommandSender #1878
Closed
@Him188 Him188 requested a review from Karlatemp June 19, 2022 11:12
@Him188 Him188 added the z:ready-to-merge 状态: PR 已经可以合并, 正在等待一些安排 label Jul 20, 2022
@Him188 Him188 force-pushed the other-client-command-sender-on-message-sync branch from 903697e to 0746002 Compare July 20, 2022 10:19
@Him188 Him188 removed the z:ready-to-merge 状态: PR 已经可以合并, 正在等待一些安排 label Jul 21, 2022
@Him188
Copy link
Member Author

Him188 commented Jul 21, 2022

要改 @since

@Him188 Him188 force-pushed the other-client-command-sender-on-message-sync branch from 0746002 to cc03438 Compare July 31, 2022 09:15
cssxsh and others added 2 commits July 31, 2022 17:17
@cssxsh @Him188
Add client properties to MessageSyncEvents, add OtherClientCommandSen…
116c22a 
…derOnMessageSync and MessageSyncEvent.toCommandSender
@Him188
Add addOtherClient for GroupExtensions for tests, add other clients…
47615e8 
… before running tests for MessageSyncEvent
@Him188 Him188 force-pushed the other-client-command-sender-on-message-sync branch from cc03438 to 47615e8 Compare July 31, 2022 09:17
@Him188 Him188 added the z:ready-to-merge 状态: PR 已经可以合并, 正在等待一些安排 label Jul 31, 2022
@Him188 Him188 merged commit bbd8941 into dev Aug 3, 2022
@Him188 Him188 deleted the other-client-command-sender-on-message-sync branch August 3, 2022 03:27
@Him188 Him188 removed this from the 2.13.0-RC milestone Aug 15, 2022
@Him188 Him188 added this to the 2.13.0-M1 milestone Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Karlatemp Karlatemp Karlatemp approved these changes

Assignees
No one assigned
Labels
s:console 子系统: mirai-console s:core 子系统: mirai-core t:feature 类型: 新特性 x:deprecation 属性: API 弃用 z:ready-to-merge 状态: PR 已经可以合并, 正在等待一些安排
Projects
None yet
Milestone
2.13.0-M1
Development

Successfully merging this pull request may close these issues.

添加对应于 MessageSyncEvent 的 CommandSender
3 participants
@Him188 @Karlatemp @cssxsh