Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support AbsoluteFolder.resolveFolderById #1712

Merged
merged 2 commits into from
Dec 6, 2021
Merged

Support AbsoluteFolder.resolveFolderById #1712

merged 2 commits into from
Dec 6, 2021

Conversation

Him188
Copy link
Member

@Him188 Him188 commented Dec 6, 2021

No description provided.

@Him188 Him188 added t:feature 类型: 新特性 N 优先级: 一般 labels Dec 6, 2021
@Him188 Him188 added this to the 2.9.0-RC milestone Dec 6, 2021
@Him188 Him188 requested a review from Karlatemp December 6, 2021 11:39
Karlatemp
Karlatemp reviewed Dec 6, 2021
View reviewed changes
Copy link
Member

@Karlatemp Karlatemp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

按照逻辑以及其他方法的行为，不是root目录是应该直接返回null

@Him188
Copy link
Member Author

Him188 commented Dec 6, 2021

确实

@Him188 Him188 requested a review from Karlatemp December 6, 2021 13:41
@Karlatemp Karlatemp added the z:ready-to-merge 状态: PR 已经可以合并, 正在等待一些安排 label Dec 6, 2021
@Him188 Him188 merged commit bc1cce3 into dev Dec 6, 2021
@Him188 Him188 deleted the resolve-folder-by-id branch December 6, 2021 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Karlatemp Karlatemp Karlatemp approved these changes

Assignees
No one assigned
Labels
N 优先级: 一般 t:feature 类型: 新特性 z:ready-to-merge 状态: PR 已经可以合并, 正在等待一些安排
Projects
No open projects
2.9.0-RC
Status: Fixed
Milestone
2.9.0-RC
Development

Successfully merging this pull request may close these issues.
2 participants
@Him188 @Karlatemp